search

minio / operator

Simple Kubernetes Operator for MinIO clusters :computer:
https://min.io/docs/minio/kubernetes/upstream/index.html
GNU Affero General Public License v3.0
1.22k stars 455 forks source link

SFTP Option should allow a separate file allowed to be configured from a secret. #1931

Open Jeremy-Boyle opened 10 months ago

Jeremy-Boyle commented 10 months ago

Is your feature request related to a problem? Please describe. Currently the SFTP private key is not configurable and would like to provide my own private key. Currently the SFTP uses the same console tls for SFTP.

Describe the solution you'd like A value in the CRD that allows you to change the the value from a secret key / path , should automatically change the deployment and mount the secret to the path that is expected when provided.

Helm chart should also be updated to allow easy configuration of the tenants.

Describe alternatives you've considered Not using minio operator

Suggestion:

spec:
  features:
    enableSFTP: true
    sftp:
      secretName: secret-name
      secretKey: (Default if not provided private.key)

Open to suggestions / changes happy to do the PR to support this.

Jeremy-Boyle commented 10 months ago

See

https://github.com/minio/operator/blob/64cb15eb5d56d35a3d45027cb23caacdbdcc1e00/pkg/resources/statefulsets/minio-statefulset.go#L313-L322

harshavardhana commented 10 months ago

This is a very low priority for us. Feel free to work on this and send a PR yourself.

cniackz commented 7 months ago

We are going to keep it open, but we are still waiting for a PR if you have time to invest and thank you ❤️

george-zubrienko commented 5 months ago

You can add a volume mount with the secret, won't that suffice?