minio / operator

Simple Kubernetes Operator for MinIO clusters :computer:
https://min.io/docs/minio/kubernetes/upstream/index.html
GNU Affero General Public License v3.0
1.19k stars 450 forks source link

`.tenant.configSecret` is unusable due to default value in `.secrets` #2283

Closed v1nsai closed 1 month ago

v1nsai commented 1 month ago

Expected Behavior

I should be able to configure .tenant.configSecret in the minio tenant helm chart without errors about .secrets even though I have not entered any config for .secrets.

Current Behavior

When entering values in .tenant.configSecret, an error is encountered because .secrets has a default value, making it impossible to use due to the error checking here. I tried adding .secrets: {} to values but that didn't work.

Possible Solution

Moving the default values from the deprecated .secrets into .tenant.configSecret seems like it would do the trick.

Steps to Reproduce (for bugs)

  1. Enter values for .tenant.configSecret, do not use .secrets at all
  2. Get error about .secrets and .tenant.configSecret being mutually exclusive

Context

Not able to preconfigure an access key or a secret key in the tenant helm chart.

Regression

Seems like this is a regression due to handling for imminent deprecation of .secrets. Operator and tenant version 6.0.2

Your Environment

ramondeklein commented 1 month ago

Duplicate of #2255.