search

minio / sidekick

High Performance HTTP Sidecar Load Balancer
GNU Affero General Public License v3.0
546 stars 82 forks source link

Remove DNS cache #83

Closed nurlan-issin closed 1 year ago

vadmeste commented 1 year ago

@nurlan-issin can you provide more description why this PR is needed ?

vadmeste commented 1 year ago

@nurlan-issin It looks like there is DNS refresh mechanism in the code. Instead of removing the DNS cache code, can you just add a code to refresh ? it is already documented here, https://github.com/rs/dnscache#usage

nurlan-issin commented 1 year ago

I believe that caching should be handled by a caching DNS server. The current implementation of dnscache ignores the ttl value of the dns record.

harshavardhana commented 1 year ago

I believe that caching should be handled by a caching DNS server. The current implementation of dnscache ignores the ttl value of the dns record.

@nurlan-issin that is the design choice, you can fix your PR and update it here. Otherwise we will fix.

nurlan-issin commented 1 year ago

@harshavardhana I'm not developer, I'm sysadmin. Can you fix this byself? The problem is invalidation doesn't work as expected. Also, incorrect dns requests are also cached. As the caching is permanent now, the only way to fix is to restart the sidekick, otherwise it is permanently broken.