search

minio / simdjson-go

Golang port of simdjson: parsing gigabytes of JSON per second
Apache License 2.0
1.8k stars 85 forks source link

all: run asmfmt #24

Closed zchee closed 3 years ago

zchee commented 3 years ago

Run github.com/klauspost/asmfmt/cmd/asmfmt.

Note that only find_odd_backslash_sequences_amd64.s file was self-edted after run asmfmt because there are Y8 => (DI) and Y9 => (SI) inline hints.

    VPCMPEQB  Y8/*(DI)*/, Y0, Y1  // vpcmpeqb    ymm1, ymm0, yword [rdi]
    VPMOVMSKB Y1, CX              // vpmovmskb    ecx, ymm1
    VPCMPEQB  Y9/*(SI)*/, Y0, Y0  // vpcmpeqb    ymm0, ymm0, yword [rsi]
zchee commented 3 years ago

@klauspost BTW, asmfmt seems doesn't support inline C style comment (actually, was added newline so might be can't compile(?)), do you have any plan support them?

klauspost commented 3 years ago

@zchee Yeah, that looks strange indeed.

klauspost commented 3 years ago

See linked issue.

zchee commented 3 years ago

@klauspost Thanks quickly! Fixed inline comment issue and reformat find_odd_backslash_sequences_amd64.s: 2847046 (#24)

zchee commented 3 years ago

@klauspost sorry, just ping.