search

minio / simdjson-go

Golang port of simdjson: parsing gigabytes of JSON per second
Apache License 2.0
1.8k stars 85 forks source link

benchmarks: split benchmarks for avoid depends unnecessary packages #56

Closed zchee closed 2 years ago

zchee commented 2 years ago

Split benchmark comparison code to avoid depending on unnecessary packages.

harshavardhana commented 2 years ago

@zchee this is a non-Go style - not sure what is the point of this change.

zchee commented 2 years ago

@harshavardhana Currently, If we use simdjson-go, will depends jsoniter (and etc) package too (yes, indirect) Imagine when if find CVE to those package, simdjson-go should upgrade those package version and cut new release. Also we should follow them because avoid security scan tools false-positive.

Those package are not related simdjson-go core implementation. Therefore I'd split root go.mod to benchmark sub-module.

zchee commented 2 years ago

@harshavardhana like https://github.com/minio/md5-simd/tree/master/_gen. But not for avo, unnecessary packages.