Cast argument of snd_seq_dump_var_event

minipli / linux-unofficial_grsec

Unofficial forward ports of the last publicly available grsecurity patch

Other

150 stars 30 forks source link

Cast argument of snd_seq_dump_var_event #14

Closed sempervictus closed 7 years ago

sempervictus commented 7 years ago

Avoids "error: passing argument 2 of ‘snd_seq_dump_var_event’ from incompatible pointer type" in sound/core/seq/oss/seq_oss_readq.c:146:36

minipli commented 7 years ago

Sorry, but your fix is wrong. You have to adapt the signature of readq_dump_sysex() instead to avoid a RAP runtime violation.

I'll fix it up myself, no worries.

Thanks for the report!

sempervictus commented 7 years ago

Thank you, will look up how you did it. We don't build for hardware with rap due to use of dkms, so this but never hit us on the virt builds which use it.

minipli commented 7 years ago

The RAP violation will only be triggered by executing this code path. Merely compiling/linking the code does not generate errors. ... RAP is CFI after all, i.e. needs a control flow, i.e. code execution ;)