minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Added openwhisk add-on #126

Closed VeerMuchandi closed 6 years ago

VeerMuchandi commented 6 years ago

I resubmitted this PR. It was reviewed yesterday.

centos-ci commented 6 years ago

Can one of the admins verify this patch?

praveenkumar commented 6 years ago

add to whitelist.

VeerMuchandi commented 6 years ago

@praveenkumar

Done.

On Wed, Jun 13, 2018 at 11:43 PM, Praveen Kumar notifications@github.com wrote:

@praveenkumar commented on this pull request.

In add-ons/openwhisk/openwhisk.addon https://github.com/minishift/minishift-addons/pull/126#discussion_r195295415 :

+ +# create project +oc new-project #{PROJECT_NAME} + +# Create OpenWhisk template +oc create -n #{PROJECT_NAME} -f https://git.io/openwhisk-template + +# Install OpenWhisk +oc new-app openwhisk-ephemeral -n #{PROJECT_NAME} + +# Assign OPENSHIFT_USERNAME as he administrator for the openwhisk project +oc adm policy add-role-to-user admin #{OPENSHIFT_USERNAME} -n #{PROJECT_NAME} + + + +# wsk property set --auth $(oc get secret whisk.auth -o yaml | grep "system:" | awk '{print $2}' | base64 --decode) --apihost $(oc get route/openwhisk --template="{{.spec.host}}")

@VeerMuchandi https://github.com/VeerMuchandi I think better to echo this command once the addon is applied you can put this command as echo so user knows what to do next without looking to readme file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-addons/pull/126#pullrequestreview-128633353, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNZf3cbLqp8o_E4uOyPzHMGu13ikiJWks5t8dv9gaJpZM4UmcBB .