search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Added htpasswd into the origin container #139

Closed jorgemoralespou closed 6 years ago

jorgemoralespou commented 6 years ago

Now htpasswd is intalled in the origin container so that it works on any ISO.

Also fixed a typo on an Env-Var

cc/ @praveenkumar @kameshsampath

centos-ci commented 6 years ago

Can one of the admins verify this patch?

gbraad commented 6 years ago

good for generic driver

Essential and perhaps even recommended from the docs?

praveenkumar commented 6 years ago

Essential and perhaps even recommended from the docs?

right, in case of generic driver we should add this addon info in the docs.

jorgemoralespou commented 6 years ago

@praveenkumar this should be fixed

praveenkumar commented 6 years ago

@jorgemoralespou you need to squash the commit messages.

jorgemoralespou commented 6 years ago

Can't this be squashed on merge by GH functionality? Do we need all this back and forth?

praveenkumar commented 6 years ago

Can't this be squashed on merge by GH functionality?

@jorgemoralespou I do not think squash can be done by GH functionality. We will locally squash and merge this.

praveenkumar commented 6 years ago

Rebased and merged.