search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Issue #129 Add scenario for removal of Che addon #140

Closed agajdosi closed 6 years ago

agajdosi commented 6 years ago

Fix https://github.com/minishift/minishift-addons/issues/129.

agajdosi commented 6 years ago

@LalatenduMohanty @amitkrout Changes around tags reverted.

agajdosi commented 6 years ago

@LalatenduMohanty please take a look when you have time

LalatenduMohanty commented 6 years ago

@agajdosi the tests are failing. https://ci.centos.org/job/minishift-addons-pr/46/console

/minishift-addons/vendor/github.com/minishift/minishift/test/integration/testsuite.shouldHaveState
09:54:38     When executing "oc project mini-che" succeeds                # testsuite.go:605 -> github.com/minishift/minishift-addons/vendor/github.com/minishift/minishift/test/integration/testsuite.ExecutingOcCommandSucceedsOrFails
09:54:38     Command 'project mini-che' did not execute successfully. cmdExit: 1, cmdErr: fork/exec /home/minishift_ci/gopath/src/github.com/minishift/minishift-addons/testing/integration-test: permission denied
agajdosi commented 6 years ago

@LalatenduMohanty thanks for noticing. Seems like there were some commits to integration tests by Praveen, which broke the functionality with 1.21.0 release, so I have updated the constraint to use versions instead of latest master. Meaning we will use latest released binary here and test code from the same release. Will see how it works on the centos-ci.

agajdosi commented 6 years ago

@LalatenduMohanty issue fixed. Passed on centos-ci + all addons pass locally. I think the issue with the way how we vendor main minishift testsuite package does not need a new issue, so I am keeping it in this PR, lets take a look how you see it :)

agajdosi commented 6 years ago

@praveenkumar @LalatenduMohanty Changes implemented.

agajdosi commented 6 years ago

@minishift/minishift-dev please take a look when you have time

agajdosi commented 6 years ago

@minishift/minishift-dev please take a look when you have time

agajdosi commented 6 years ago

@minishift/minishift-dev please take a look when you have time

agajdosi commented 6 years ago

@minishift/minishift-dev can somebody merge, please?

agajdosi commented 6 years ago

Closing this as there is no will to merge.

gbraad commented 6 years ago

@LalatenduMohanty did you look at this after the requested change?