search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Adding Strimzi addon #164

Open matzew opened 6 years ago

matzew commented 6 years ago

For https://github.com/minishift/minishift-addons/issues/163 I've added a Strimzi add-on!

centos-ci commented 6 years ago

Can one of the admins verify this patch?

matzew commented 6 years ago

@kameshsampath I've added a Strimzi add-on,

might be handy w/ your recent work.....

matzew commented 6 years ago

@gbraad ah, yeah - sorry. that was an accident - pushed to early :-(

matzew commented 6 years ago

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew commented 6 years ago

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew commented 6 years ago

Updated using the latest version of Strimzi.

@kameshsampath @gbraad any comments?

matzew commented 6 years ago

updated to 0.8.1 of Strimzi

kameshsampath commented 6 years ago

looks good to me, its better to release for latest version when releasing first version of addon

matzew commented 6 years ago

this is latest version

On Mon 22. Oct 2018 at 10:42, Kamesh Sampath notifications@github.com wrote:

looks good to me, its better to release for latest version when releasing first version of addon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-addons/pull/164#issuecomment-431769763, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJnznMkVJIlJl4Z72GonLOvAJan1OS1ks5unYTXgaJpZM4XAg7J .

-- Sent from Gmail Mobile

kameshsampath commented 6 years ago

I know thats why I voted for it :)

matzew commented 6 years ago

@gbraad I've addressed your original concerns - and it's now pointing to the latest

matzew commented 6 years ago

@praveenkumar @gbraad updated w/ version requirements and also added a simple test

praveenkumar commented 6 years ago

add to whitelist.

praveenkumar commented 6 years ago

@matzew can you please squash the commit into single one (I can see 5 commits associated to this PR)?

matzew commented 6 years ago

@praveenkumar I've squashed to be one commit - sorry for the noise !

praveenkumar commented 6 years ago

@gbraad can you take a look and if seem alright then let's merge it.

matzew commented 6 years ago

@gbraad / @praveenkumar any comments on this ?

anjannath commented 5 years ago

retest this please

praveenkumar commented 5 years ago

@gbraad ping, I already approved it long back.

anjannath commented 5 years ago

Apart from the Var-Defaults change request, the add-on is working fine, all the deployments/operators are running :+1:

gbraad commented 5 years ago

+1 OK.

Waiting for the final changes

On Mon, Feb 11, 2019 at 5:43 PM Anjan Nath notifications@github.com wrote:

Apart from the Var-Defaults change request, the add-on is working fine, all the deployments/operators are running

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]