search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Remove dynamic-admission-controllers #171

Closed matzew closed 5 years ago

matzew commented 5 years ago

See https://github.com/minishift/minishift-addons/issues/170 See bgzilla 1635918

the config changed for 3.11 due to a bug ...

Not sure this should be merged... oping for discussion

CC @kameshsampath

centos-ci commented 5 years ago

Can one of the admins verify this patch?

matzew commented 5 years ago

With 4.0 that is not needed

matzew commented 5 years ago

Discussed w/ @kameshsampath and we both think that getting rid of this addon is best.

given that the change is better done w/ minishift patch and it's a one time thing per instance/cluster

kameshsampath commented 5 years ago

@matzew Agree with @matzew and IMHO having an addon per command is a overkill.

praveenkumar commented 5 years ago

@kameshsampath @matzew So we should close this PR right?