search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

fix: fix the CORS addon to use the right container #187

Closed wei-lee closed 4 years ago

wei-lee commented 5 years ago

I discovered that the CORS addon does't work anymore on this version of minishift:

minishift v1.33.0+ba29431

After investigation I believe it is not using the right container. Now I am using labels to try to find the right container and then update the config file.

centos-ci commented 5 years ago

Can one of the admins verify this patch?

psturc commented 5 years ago

👍 works for me with minishift v1.33.0+ba29431 as well. +1 on merging this.

anjannath commented 4 years ago

ok to test

anjannath commented 4 years ago

Thanks @wei-lee