search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Tag repository with minishift version #26

Open jorgemoralespou opened 7 years ago

jorgemoralespou commented 7 years ago

We should tag/branch this repository when a minishift version happens so we can keep compatibility between the addons here provided and the minishift versions.

At some point in time we might want to provide 2 different versions of an addon, to support old minishift versions (CDK) and new minishift versions that provide new features (e.g. multiline descriptions in 1.5.0 that do not work in previous releases).

gbraad commented 7 years ago

This would not guarantee that an add-on will work. I hope the author will check their add-ons from time to time. But also, the add-ons here are outside of our support. They are meant as a way for the community to distribute their work.

I think this should actually the solved by https://github.com/minishift/minishift/issues/1313

gbraad commented 7 years ago

removed comments and moved to a new issue

hferentschik commented 7 years ago

Tagging alone won't indeed help I think. I think in this case we need to make compatibility more explicit. We already discussed this in the Minishift issue https://github.com/minishift/minishift/issues/1134, where we talked about introducing an additional optional meta data header to enforce a certain OpenShift version. The same could be done (if needed for Minsihift version). This way, add-on developers can gain some more control for add-ons where these things matters. Other add-ons I expect to stay stable, unless even the OpenShift API changes in a major way.

LalatenduMohanty commented 7 years ago

minishift/minishift#1134 and minishift/minishift#1313 together should be enough I think. We can keep this issue open just to track the two issues in Minishift repository .