search

minishift / minishift-addons

A repository for the community to exchange Minishift add-ons
Apache License 2.0
71 stars 86 forks source link

Check current minishift config when enabling/applying che addon. #45

Open rhopp opened 7 years ago

rhopp commented 7 years ago

We are suggesting user to increase minishift memory to 5GB before enabling/applying che addon (in readme?). It would be nice, if "minishift addon enable che" would check current minishift config and if it is below 5GB, it would print message like:

Che addon required at least 5GB RAM of minishift virtual machine. Your current config is at 2GB. Do you want to increase this to 5GB? [y/n]

Or at least print how it could be done.

coolbrg commented 7 years ago

@rhopp

I think we can't do much from minishift side as we can't track which addon has which configuration.

I think the addon can itself check initially if VM has enough memory or not and then exit with message.

coolbrg commented 7 years ago

Any opinion @minishift/minishift-dev ?

rhopp commented 7 years ago

I think the addon can itself check initially if VM has enough memory or not and then exit with message. That's exactly what I had on my mind ;-)

gbraad commented 7 years ago

This is not Che addon specific. this could be part of the meta-data, just like minimum OpenShift version, etc.

LalatenduMohanty commented 7 years ago

I think the addon can itself check initially if VM has enough memory or not and then exit with message.

Do you mean through add-on ssh command.

gbraad commented 7 years ago

through add-on ssh command

I hope not... as this moves logic for something generic into an add-on install... a think a 'Minimum Memory' variable in the ad-on header would be sufficient/possible.

agajdosi commented 6 years ago

@LalatenduMohanty @gbraad This seems like feature request for Minishift, shall we migrate the issue to appropriate issue tracker?