search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Issue #49 Update docker version to 1.12.6 #50

Closed praveenkumar closed 7 years ago

coolbrg commented 7 years ago

@praveenkumar as per docker 1.12.6 commit, path has now changed from /make_iso.sh to /tmp/make_iso.sh. See here https://github.com/boot2docker/boot2docker/commit/f3e4485ff8fb2f5aa81d1f7834a82fa5ec33aeaf.

gbraad commented 7 years ago

will this update to a new boot2docker with a more recent kernel version? because the current version has a possible issue with Ryzen CPUs: https://github.com/minishift/minishift/issues/1022

hferentschik commented 7 years ago

@praveenkumar @budhrg I think this relates to issues #26

hferentschik commented 7 years ago

I am also wondering why we not should update to the latest available version issue #28. Obviously there are cases to be made for either. This pull requests aligns Docker versions between our ISOs. Upgrading to the latest gives user some more features.

praveenkumar commented 7 years ago

I am also wondering why we not should update to the latest available version issue #28.

Right, I think this will resolve #28 also but as I mentioned on the issue, we should have consistent docker version across all our ISO and right now it's 1.12.6

coolbrg commented 7 years ago

I mentioned on the issue, we should have consistent docker version across all our ISO and right now it's 1.12.6

That's means why not go for 1.13.1 which is the last version before they moved to community edition (CE) kind of version (See here). Let sync this version is CentOS ISO too.

hferentschik commented 7 years ago

@praveenkumar can we not upgrade the CentOS ISO version as well? Or is there nothing later?

praveenkumar commented 7 years ago

Let sync this version is centos ISO too.

@budhrg , @hferentschik No, docker version which part of centos is comes from offical repo and we don't have ownership there and we should not use unofficial repo for CentOS just for docker version upgrade because same version what stick to our RHEL ISO also.

coolbrg commented 7 years ago

@praveenkumar Please update commit message with docker version for easy track.

praveenkumar commented 7 years ago

@gbraad let CI run for this and then we can merge this PR.

coolbrg commented 7 years ago

@praveenkumar CI is fine. Now, it can be merged.