search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Issue #51 Add GitLab CI runner #52

Closed gbraad closed 7 years ago

gbraad commented 7 years ago

Fixes #51

Add GitLab CI runner definition

Note: some changes are needed to allow shared runners

gbraad commented 7 years ago

Currently a restriction as for shared/public runners we rely on docker-in-docker to build the images. This happens due a very minimal image docker:dind. It also does not provide make. Working on improving this... This was a first attempt.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

coolbrg commented 7 years ago

docker:dind. It also does not provide make. Working on improving this... This was a first attempt.

:+1: Got you.

gbraad commented 7 years ago

Using Docker-in-Docker using a Fedora 26 image. Which allows me to run our regular build process using make. By removing the intermediate container images, we can run on shared CI runners.

gbraad commented 7 years ago
gbraad commented 7 years ago

Note: intermediate docker images are removed when REMOVE_CONTAINER_IMAGES is set to a value. This is meant to keep disk usage to a minimum

hferentschik commented 7 years ago

So this is a WIP?

gbraad commented 7 years ago

WIP status was removed 15 hours ago ;-)

hferentschik commented 7 years ago

What's the empty "iso/.gitlab-ci.yml" for?

gbraad commented 7 years ago

Any feedback? @praveenkumar @LalatenduMohanty @budhrg ?

coolbrg commented 7 years ago

Looks good to me @gbraad