search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Issue #33 #32 Fix gh-release and added release instructions #53

Closed coolbrg closed 7 years ago

coolbrg commented 7 years ago

Fix #32 and #33

cc @hferentschik @LalatenduMohanty

Please check in Mac by release to your own fork.

coolbrg commented 7 years ago

I am not able to test in Linux OS too. Getting some gh-release specific error locally: 

$ make release
go get -u github.com/progrium/gh-release/...
# rm -rf release &&
mkdir -p release
cp /home/budhram/redhat/minishift-b2d-iso/build/minishift-b2d.iso release/
gh-release checksums sha256
/tmp/bashenv.433487048: line 63: syntax error near unexpected token `('
/tmp/bashenv.433487048: line 63: `export BASH_FUNC_module()=$'() {  eval `/usr/bin/modulecmd bash $*`'
/home/budhram/.basher/bash: main: command not found
Makefile:35: recipe for target 'release' failed
make: *** [release] Error 127
coolbrg commented 7 years ago

Definitely some issue with gh-release with its dependency in Windows OS. Probably might be the reason, the author is also not publishing windows artifacts.

PS C:\minishift-b2d-iso> make release
go get -u github.com/progrium/gh-release/...
# github.com/progrium/go-basher
C:\gowork\src\github.com\progrium\go-basher\basher.go:52: undefined: RestoreAsset
make: *** [C:\gowork/bin/gh-release] Error 2
hferentschik commented 7 years ago

Definitely some issue with gh-release with its dependency in Windows OS

I don't think this is a a problem for now. For my part I was able to successfully release to my fork.

coolbrg commented 7 years ago

For my part I was able to successfully release to my fork.

Thanks for testing. I am having some issue (https://github.com/minishift/minishift-b2d-iso/pull/53#issuecomment-321790267) locally so couldn't test with my fork but definitely should work as I didn't change anything gh-release specific.

hferentschik commented 7 years ago

@LalatenduMohanty, do you mind giving it a try?

LalatenduMohanty commented 7 years ago

@budhrg I have done previous releases on a CentOS VM and it worked fine. But on Fedora this issue exists https://github.com/progrium/gh-release/issues/19

coolbrg commented 7 years ago

With my CentOS VM, I am getting exit code 2 .

$ make release
make release
rm -rf release && mkdir -p release
cp /home/budhram/redhat/minishift-b2d-iso/build/minishift-b2d.iso release/
gh-release checksums sha256
Writing sha256 checksum files...
gh-release create budhrg/minishift-b2d-iso 1.1.0 master v1.1.0
Creating release v1.1.0 from branch master ...
make: *** [release] Error 2