minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Fixes #28 Update B2D to v1.13.1 #54

Closed gbraad closed 7 years ago

gbraad commented 7 years ago

Fixes #28

Artifacts:

gbraad commented 7 years ago

Already did so on my personal copy on GitLab. Was away from home... Build passed already ;-) https://gitlab.com/gbraad/minishift-b2d-iso/-/jobs/29206639

Note: wasn't even aware I already proposed it as a PR.

coolbrg commented 7 years ago

With this PR, another similar PR https://github.com/minishift/minishift-b2d-iso/pull/50 looks invalid.

WDYT @gbraad @hferentschik @LalatenduMohanty @praveenkumar ?

Can we close #50 ?

praveenkumar commented 7 years ago

@gbraad @budhrg I am fine with this PR as long as we consist about our docker version across the ISO as I mentioned to #50 also.

hferentschik commented 7 years ago

Was the plan not to have aligned versions of Docker in B2D and CentOS ISO? I seem to recall that we said we will defer upgrading to the latest available version and hence deferring issue #28. Instead we said we align versions. Do I recall this wrong? Have we changed the opinion?

hferentschik commented 7 years ago

@praveenkumar @gbraad @budhrg - seems we forgot about this and pr #50. Can we get either merge #50 or this modify this pull request in order to upgrade the Docker version and align with what we have in CentOS ISO. After that we should be able to cut a release and make sure to update to the latest version in Minishift.

coolbrg commented 7 years ago

this modify this pull request in order to upgrade the Docker version and align with what we have in CentOS ISO

50 align the docker version with that of centos iso. I suggest to pull changes from #50 and add your changes on top of that as additional commit.

hferentschik commented 7 years ago

I suggest to pull changes from #50 and add your changes on top of that as additional commit.

+1 Whatever makes sense. Would be nice to get this merged asap, so that we have a full sprint to use the new updated ISO.