[WIP] Issue #59 Test hvkvp inclusion

gbraad commented 7 years ago

We can publish files on gh-pages if needed, as part of the minishift organization. As b2d is easy, it just needs to download it, so it can even be on the releases...

but for the CentOS live cd creation we need a repo structure, although it can be on gh-pages, it needs a little bit more work.

On Thu, Sep 7, 2017 at 1:57 PM, Lalatendu Mohanty notifications@github.com wrote:

@LalatenduMohanty commented on this pull request.

In iso/Dockerfile https://github.com/minishift/minishift-b2d-iso/pull/61#discussion_r137451108 :

@@ -45,8 +45,15 @@ RUN for dep in $HOST_FOLDER_DEPS; do \ rm -f "/tmp/$dep.tcz"; \ done

+# Add Hyper-V Data Exchange client +RUN curl -fSL -o "/tmp/go-hvkvp.tcz" "https://files.gbraad.nl/hvkvp/go-hvkvp-0.0.3.tcz"; \

Wondering if we find a place for this where other contributors can get access if any modification required. This is fine for testing and long term we need place for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-b2d-iso/pull/61#pullrequestreview-61118577, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZrdytE5ML-BzhDwyoiepHdVYnyxTks5sf4WugaJpZM4PPPEc .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

gbraad commented 7 years ago

15:41:22 
15:41:22 *******
15:41:22 Executing command : /root/payload/tests/../build/bin/minishift delete
15:41:22 *******
15:41:22 
15:41:22 Reproduced traceback from: /usr/lib/python2.7/site-packages/avocado/core/test.py:603
15:41:22 Traceback (most recent call last):
15:41:22   File "/root/payload/tests/test.py", line 101, in test_delete_vm
15:41:22     self.execute_test({ 'cmd': cmd })
15:41:22   File "/root/payload/tests/test.py", line 120, in execute_test
15:41:22     self.assertEqual(0, process.returncode)
15:41:22   File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual
15:41:22     assertion_func(first, second, msg=msg)
15:41:22   File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual
15:41:22     raise self.failureException(msg)
15:41:22 AssertionError: 0 != 1
15:41:22 
15:41:22 Local variables:
15:41:22  -> self <class 'test.MinishiftISOTest'>: 10-tests/test.py:MinishiftISOTest.test_delete_vm
15:41:22  -> cmd <type 'str'>: /root/payload/tests/../build/bin/minishift delete
15:41:22 FAIL 10-tests/test.py:MinishiftISOTest.test_delete_vm -> AssertionError: 0 != 1

@LalatenduMohanty did the m delete command change behaviour?

LalatenduMohanty commented 7 years ago

@gbraad Yes, please use minishift delete --force as just minishift delete will ask for confirmation.

gbraad commented 7 years ago

@budhrg assigned #69 to me, so it seems I will need to cherry-pick my fix and create a new commit for this as part of this or new PR. /cc: @LalatenduMohanty

;-)

gbraad commented 7 years ago

Need to include a test to see if hvkvp got installed correctly. Just now a timeout was reported and the install/unpack did not succeed.

gbraad commented 7 years ago

Currently not able to support B2D to get a consistent outcome. Will reconsider when more information is available.

minishift / minishift-b2d-iso

[WIP] Issue #59 Test hvkvp inclusion #61

@LalatenduMohanty commented on this pull request.