search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Upgrade to boot2docker v17.09.0-ce #75

Open vcottagiri opened 7 years ago

vcottagiri commented 7 years ago

It will be great if we can upgrade to the latest version of boot2docker so that we can use latest docker verson 17.09.0-ce in minishift

gbraad commented 7 years ago

Related to #28, #49:

I see you created https://github.com/minishift/minishift-b2d-iso/pull/76, but unfortunately, it is not as simple as upgrading to the latest version. Even a slightly less old version was denied for merging: https://github.com/minishift/minishift-b2d-iso/pull/54. This ISO solved several issues related to virtualbox, kernel support, updated extensions, etc. The version decided was eventually to go for something that aligns to Docker which is available in the CentOS images

/cc: @praveenkumar WDYT? Personally I do not think we can maintain the idea to align the versions...

I still wonder about https://github.com/gbraad/minishift-b2d-iso/issues/1 Why do we want to control the version of Docker to install? As this breaks the relation between the ISO and the Docker version inside. it actually gives us an untested situation in which we can not file issues against the upstream repo for boot2docker. (Note: however, filed issues go unnoticed and unanswered most of the time anyways)

vcottagiri commented 7 years ago

Ok, I see. FWIW - I have not come across any issues yet with docker v17.09.0-ce. Minishift works just fine.

praveenkumar commented 7 years ago

Looks like lot of registry push is broken for docker which we are using for b2d (at least for fedora I am not able to push images to internal registry https://github.com/minishift/minishift/issues/817) if those issue can be solved by updating the docker version for b2d then I am good with this change.

@minishift/minishift-dev wdyt?

praveenkumar commented 7 years ago

@vcottagiri can you send a PR so atleast we can see if CI passes with those changes and we can test artifacts on different issues also.

vcottagiri commented 7 years ago

@praveenkumar - There is a PR #76 for this, or are you expecting something else?

gbraad commented 6 years ago

@xqianwang can you explain why the newer Docker version is important to you? Which functionality areyou missing, or is to align versions in your environment?

nathkn commented 6 years ago

@gbraad Docker has seen a number of changes since Docker v1.13.1 over a year and a half ago. Minikube has been upgraded to 17.12-ce as well.

One of the main ones being multistage builds which is becoming the standard of how docker builds work.

Could we see some movement on upgrading the docker version for minishift?