search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Issue #6 Upgrade to latest Docker version #8

Closed coolbrg closed 7 years ago

coolbrg commented 7 years ago

Fix #6

Tested the ISO generated with the suggested changes and minishift start working fine with proper boot2docker version and docker version.

Boot2Docker version 1.12.3, build HEAD : 7fc7575 - Thu Oct 27 17:23:17 UTC 2016
Docker version 1.12.3, build 6b644ec

Full logs - https://gist.github.com/budhrg/2858071ec621271b9084622a99a8ad9f

LalatenduMohanty commented 7 years ago

@budhrg Closing your PR as we want to recreate the repository without the minikube directory. Please resend the PR if required later.

LalatenduMohanty commented 7 years ago

@budhrg We could fix the issue with the repository without deleting it. Hence I am re-opening your PR. However We had to git force push some changes, overwriting the exiting commits, so you need to rebase your PR as per the new master.

coolbrg commented 7 years ago

@LalatenduMohanty Updated the PR after getting rebased with upstream master.

LalatenduMohanty commented 7 years ago

LGTM. Tested the build and minishift start --iso-url with the newly built ISO.