search

minishift / minishift-b2d-iso

ISO based on Boot2Docker for Minishift
Apache License 2.0
9 stars 13 forks source link

Issue #64 build, pull and push of container images #80

Closed gbraad closed 3 years ago

gbraad commented 6 years ago

Fix #64

Will have to remove/replace

  - docker login -u gbraad -p $DOCKER_PASSWORD

but this is something I used before to prevent the rebuild of the images for socat, ethtool, etc

LalatenduMohanty commented 6 years ago

@gbraad To make this PR to work , we first need to push the intermediate images to github, right?

gbraad commented 6 years ago

AFAIR this is to force a truth check. If you have another option that works from the dind based shell, let me know. They do not use bash... and this works accross the board with dind images and our CI option

On Tue, Apr 24, 2018 at 3:55 PM, Lalatendu Mohanty <notifications@github.com

wrote:

@LalatenduMohanty commented on this pull request.

In iso/build.sh https://github.com/minishift/minishift-b2d-iso/pull/80#discussion_r183635583 :

@@ -31,22 +31,25 @@ docker run $DOCKER_RUN_OPTIONS jpetazzo/nsenter cat /nsenter > $tmpdir/nsenter &

do not remove nsenter, as this image is not big, and quite generally used

Get socat

-docker build -t socat -f Dockerfile.socat . -docker run $DOCKER_RUN_OPTIONS socat cat socat > $tmpdir/socat +[ "${BUILD_CONTAINER_IMAGES+1}" ] && docker build -t minishift/b2d-socat -f Dockerfile.socat .

Why the +1 in ${BUILD_CONTAINER_IMAGES+1} . If anyone wants to build the images locally we can set export BUILD_CONTAINER_IMAGES=1, right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-b2d-iso/pull/80#pullrequestreview-114668284, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZmydbjwyTqST2TPbOxhKoF9oAm4Kks5trtpdgaJpZM4RMSTL .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

gbraad commented 6 years ago

retest this please