minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

[WIP] Fix for minishift#394 Enable direct lvm #100

Closed gbraad closed 7 years ago

gbraad commented 7 years ago

This fix is needed to enable LVM support in the CentOS/RHEL images; https://github.com/minishift/minishift/issues/394

gbraad commented 7 years ago

Rebase can happen after #97 is merged

hferentschik commented 7 years ago

So the test fails, since we need changes in Minishift as well?

hferentschik commented 7 years ago

@gbraad can you create an issue in this repo as well and make the commit against this issue. We need to track changes to the ISO here. Also, I think we can squash the commits.

hferentschik commented 7 years ago

The milestone for the issue would be v1.0.0-cr.2

hferentschik commented 7 years ago

Let's get the outstanding pull requests in this repo merged asap, so that we can cut a release.

gbraad commented 7 years ago

Will create an issue which refers to minishift/minishift#394

gbraad commented 7 years ago

fails

I saw an issue with 500 Internal server error on downloading Glide.

coolbrg commented 7 years ago

@gbraad

Rebase can happen after #97 is merged

Looks like #97 is merged. Could you rebase PR too?

gbraad commented 7 years ago

Issues with rebasing... Tried from the command line and this resulted in a dropped commit. Seems the same occurs in the web editor. Will resolve this manually.

hferentschik commented 7 years ago

Will resolve this manually.

+1

gbraad commented 7 years ago

Closing as we will likely go with overlay