minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #107 Adding sshfs #108

Closed hferentschik closed 7 years ago

hferentschik commented 7 years ago

@praveenkumar I am not quite sure where I can find fuse-sshfs for the RHEL ISO case. I guess it must be somewhere, since we used it for CDK 2.x as well right?

Also, I had a hard time finding the values for the various repo env variables. In the end I found them in the build config for the Jenkins ISO build. I guess we should add something to the Mojo, wdyt?

praveenkumar commented 7 years ago

I am not quite sure where I can find fuse-sshfs for the RHEL ISO case. I guess it must be somewhere, since we used it for CDK 2.x as well right?

Right we did used it for CDK2.x and it's in a different tree not in the RHEL tree, will add that details to mojo.

Also, I had a hard time finding the values for the various repo env variables. In the end I found them in the build config for the Jenkins ISO build. I guess we should add something to the Mojo, wdyt?

I agree will update this to mojo.

praveenkumar commented 7 years ago

retest this please

hferentschik commented 7 years ago

@praveenkumar Building the RHEL ISO worked now :-) I added a sanity check. Not sure whether it passes yet. Might need to adjust according to the outcome of the CI build.

hferentschik commented 7 years ago

BTW, the equivalent for B2D - https://github.com/minishift/minishift-b2d-iso/pull/36

hferentschik commented 7 years ago

@praveenkumar I think it is good to go now. I pushed a failing regex once to make sure that the test will really fail, if there is not the expected output. I reverted it back now to the regexp which already passed the CI once.

coolbrg commented 7 years ago

Verified locally, tests passed too. Merged! Thanks.