minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

[WIP] Issue #116 remove RPM and Yum #117

Closed gbraad closed 7 years ago

gbraad commented 7 years ago

Fixes #119 by completely removing yum and rpm functionality

gbraad commented 7 years ago

http://artifacts.ci.centos.org/minishift/minishift-centos-iso/pr/117

coolbrg commented 7 years ago

@gbraad , is it still in WIP?

http://artifacts.ci.centos.org/minishift/minishift-centos-iso/pr/117 I tested the artifact and couldn't found yum and rpm.

LGTM :+1:

Looks like you need to resolve git conflict.

gbraad commented 7 years ago

This was decided against.

@praveenkumar WDYT about closing this?

praveenkumar commented 7 years ago

@gbraad @budhrg right so now we have banner which give warning when someone try to use yum to install packages so I think we can close this PR.

gbraad commented 7 years ago

We can always re-open when needed

gbraad commented 7 years ago

A newer approach could be to disallow installing due to a file in the root, called .yum-unsupported, which on provisioning with MINISHIFT_ENABLE_EXPERIMENTAL=y will be removed. Allowing the installing to succeed with a banner... but if the file exists, it will not continue.