minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #116 Show banner when installing packages using `yum` #119

Closed gbraad closed 7 years ago

gbraad commented 7 years ago

Deals with #116

Note: Banner might need to be more prominent...

gbraad commented 7 years ago

@praveenkumar livecd-creator seems to interpret the $@ and $answer, and writes "" to the livecd filesystem.

praveenkumar commented 7 years ago

@gbraad we need to make change to rhel template also because we want this for RHEL iso too right?

gbraad commented 7 years ago

I would like to, but can not make this call. As I remember developer tools do not follow the same support anyways. /cc: @LalatenduMohanty

LalatenduMohanty commented 7 years ago

@gbraad @praveenkumar Agree, we need to change RHEL ISO also.

gbraad commented 7 years ago

RHEL

done...

gbraad commented 7 years ago

This includes #123, so if rebasing... that PR should go first

LalatenduMohanty commented 7 years ago

@gbraad Please fix the merge conflict.

gbraad commented 7 years ago

We need to confirm the link first, before able to merge. Don't want to do 2 pushes to get this done.

LalatenduMohanty commented 7 years ago

We need to confirm the link first, before able to merge. Don't want to do 2 pushes to get this done.

Right. First we need https://docs.openshift.org/latest/minishift/using/troubleshooting.html#install-additional-software-not-supported to be up i.e. https://github.com/minishift/minishift/issues/1152

praveenkumar commented 7 years ago

Test with RHEL ISO and worked as exected

$ ./minishift ssh
[docker@minishift ~]$ sudo yum install vim
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Installing additional packages on the root filesystem might exceed the allocated overlay size and lock the Minishift VM. Proceed with the installation at your own risk.
For more information, see https://docs.openshift.org/latest/minishift/using/troubleshooting.html#root-filesystem-exceeds-overlay-size
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Are you sure you want to continue? [y/N]
n
[docker@minishift ~]$ sudo yum install vim
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Installing additional packages on the root filesystem might exceed the allocated overlay size and lock the Minishift VM. Proceed with the installation at your own risk.
For more information, see https://docs.openshift.org/latest/minishift/using/troubleshooting.html#root-filesystem-exceeds-overlay-size
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Are you sure you want to continue? [y/N]
y
Loaded plugins: product-id, search-disabled-repos, subscription-manager
gbraad commented 7 years ago

@praveenkumar also verify, although late, if yum install -y vim works. It should show the banner, but not show the continue prompt.