minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Getting bash related errors during 'make release' #170

Closed coolbrg closed 7 years ago

coolbrg commented 7 years ago

Getting some bash shell related errors while trying to release in Fedora 26.

$ make release
mkdir -p /home/budhram/redhat/minishift-centos-iso/build
curl -sL https://github.com/progrium/gh-release/releases/download/v2.2.1/gh-release_2.2.1_linux_x86_64.tgz > /home/budhram/redhat/minishift-centos-iso/build/gh-release_2.2.1_linux_x86_64.tgz
tar -xvf /home/budhram/redhat/minishift-centos-iso/build/gh-release_2.2.1_linux_x86_64.tgz -C /home/budhram/redhat/minishift-centos-iso/build
gh-release
rm -fr /home/budhram/redhat/minishift-centos-iso/build/gh-release_2.2.1_linux_x86_64.tgz
rm -rf release && mkdir -p release
cp /home/budhram/redhat/minishift-centos-iso/build/minishift-centos7.iso release/
/home/budhram/redhat/minishift-centos-iso/build/gh-release checksums sha256
/tmp/bashenv.957532623: line 40: export: `BASH_FUNC_scl%%=() {  local CMD=$1;
 if [ "$CMD" = "load" -o "$CMD" = "unload" ]; then
 eval "module $@";
 else
 /usr/bin/scl "$@";
 fi
}': not a valid identifier
/tmp/bashenv.957532623: line 80: export: `BASH_FUNC_module%%=() {  eval `/usr/bin/modulecmd bash $*`
}': not a valid identifier
Writing sha256 checksum files...
/home/budhram/redhat/minishift-centos-iso/build/gh-release create minishift/minishift-centos-iso 1.3.0 master v1.3.0
/tmp/bashenv.795568438: line 40: export: `BASH_FUNC_scl%%=() {  local CMD=$1;
 if [ "$CMD" = "load" -o "$CMD" = "unload" ]; then
 eval "module $@";
 else
 /usr/bin/scl "$@";
 fi
}': not a valid identifier
/tmp/bashenv.795568438: line 80: export: `BASH_FUNC_module%%=() {  eval `/usr/bin/modulecmd bash $*`
}': not a valid identifier
Creating release v1.3.0 from branch master ...
make: *** [Makefile:83: release] Error 2
LalatenduMohanty commented 7 years ago

@budhrg You should run make release in a CentOS VM as the CentOS ISO created on Fedora does not work as expected.

LalatenduMohanty commented 7 years ago

Also I think I have seen this issue when I run make release on Fedora. Not sure what is the root cause. @praveenkumar do you remember?

gbraad commented 7 years ago

Never release from a fedora build. This will result in a VM that can not be logged in to.

I do not see a need to further investigate. It is the practice to create the livecd from the same or close to same version of the OS you want to create.

coolbrg commented 7 years ago

Closing this issue as it is not recommended to release from Fedora workstation.