minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #176 Update tests to be run in macOS #177

Closed coolbrg closed 6 years ago

coolbrg commented 6 years ago

Fix #176

Also fixes #166

Just a replication of b2d fix for macOS

coolbrg commented 6 years ago

do we know where those mac specific test should run once we have it in?

Seems to be for local experience so that one can run these tests easily on their Mac machine.

praveenkumar commented 6 years ago

@budhrg Able to get minishift darwin binary but there is a problem, On mac to run tests we need to explicit download the centos ISO because we can't able to create it on here :( now question is from where (either from the ci.centos artifacts or run a vagrant command and create). There is nothing logical wrong in this PR but you need to put some docs on how to test it on MacOS.

coolbrg commented 6 years ago

There is nothing logical wrong in this PR but you need to put some docs on how to test it on MacOS.

:+1: You are right. We need more things here rather than just fixing the test. Probably documentation will help as you mentioned.

anjannath commented 6 years ago

now question is from where (either from the ci.centos artifacts or run a vagrant command and create)

Running the tests by downloading the prebuilt iso doesn't add much value IMO, because when i change something then only i want to run tests to make sure everything is in order. The README already has instructions on how to build the iso using vagrant. What other documentation do we need here?

coolbrg commented 6 years ago

@praveenkumar , Added some documentation changes. see below screenshot from 2017-12-14 13-01-51

praveenkumar commented 6 years ago

@budhrg We need to rethink about this effort. I am sure there is no harm in talking this PR in but when we say enable testing for Mac that means user have to do follow before they can have the end result.

coolbrg commented 6 years ago

@praveenkumar @LalatenduMohanty , please review it. Updated the README.