Closed coolbrg closed 6 years ago
do we know where those mac specific test should run once we have it in?
Seems to be for local experience so that one can run these tests easily on their Mac machine.
@budhrg Able to get minishift darwin binary but there is a problem, On mac to run tests we need to explicit download the centos ISO because we can't able to create it on here :( now question is from where (either from the ci.centos artifacts or run a vagrant command and create). There is nothing logical wrong in this PR but you need to put some docs on how to test it on MacOS.
There is nothing logical wrong in this PR but you need to put some docs on how to test it on MacOS.
:+1: You are right. We need more things here rather than just fixing the test. Probably documentation will help as you mentioned.
now question is from where (either from the ci.centos artifacts or run a vagrant command and create)
Running the tests by downloading the prebuilt iso doesn't add much value IMO, because when i change something then only i want to run tests to make sure everything is in order. The README
already has instructions on how to build the iso using vagrant
. What other documentation do we need here?
@praveenkumar , Added some documentation changes. see below
@budhrg We need to rethink about this effort. I am sure there is no harm in talking this PR in but when we say enable testing for Mac that means user have to do follow before they can have the end result.
make test
on native (MacOS) box. (provided he has make
installed on system)@praveenkumar @LalatenduMohanty , please review it. Updated the README.
Fix #176
Also fixes #166
Just a replication of b2d fix for macOS