minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #180 #191 Allow multiple network configuration files and support for RHEL #179

Closed gbraad closed 6 years ago

gbraad commented 6 years ago

Fixes #180, #191

Needed for allow multiple network configuration files: https://github.com/minishift/minishift/issues/1457

Signed-off-by: Gerard Braad me@gbraad.nl

gbraad commented 6 years ago

Testing on VirtualBox with the following configuration files:

cat /var/lib/minishift/networking-eth0

DEVICE=eth0
USEDHCP=y

cat /var/lib/minishift/networking-eth1

DEVICE=eth1
IPADDR=192.168.235.100
NETMASK=24
GATEWAY=192.168.235.1
DNS1=8.8.8.8
DNS2=8.8.4.4

Should also allow to use DHCP on multiple interfaces cat /var/lib/minishift/networking-eth1

DEVICE=eth1
USEDHCP=y
gbraad commented 6 years ago

Forcing assignment of the address by DHCP on both network interfaces; eth0 and eth1, as it is easier for us to et device information from the lease file.

gbraad commented 6 years ago

Have to store the initial config as part of the userdata as /var/lib/minishift gets removed on initial startup

gbraad commented 6 years ago

dhclient messes up the DNS configuration when used as two different interfaces. Need to check how NM handles this (up script?). At the moment it only registers DNS for the last device 192.168.42.1, while 192,168.122.1 actually provides NAT.

gbraad commented 6 years ago

Modifications to /usr/sbin/dhclient-script were needed to keep the old nameservers.

gbraad commented 6 years ago

http://artifacts.ci.centos.org/minishift/minishift-centos-iso/pr/179/

gbraad commented 6 years ago

Added support for

DISABLED=y
gbraad commented 6 years ago

@praveenkumar This needs testing for RHEL, as it also includes the #191 patches.

gbraad commented 6 years ago

@anjannath added a $DEVICE existence check, but the issue actually comes from Minishift

gbraad commented 6 years ago

@praveenkumar updated with ${hvkvp_repo_url}

coolbrg commented 6 years ago

retest this please

coolbrg commented 6 years ago

retest this please

gbraad commented 6 years ago
09:24:25 Error starting the cluster: Error attempting to download and cache oc: Cannot download OpenShift release asset 5165547: GET https://api.github.com/repos/openshift/origin/releases/assets/5165547: 403 API rate limit exceeded for 8.43.84.199. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.); rate reset in 10m49.649007513s
gbraad commented 6 years ago

retest this please

coolbrg commented 6 years ago

@gbraad , this PR https://github.com/minishift/minishift-centos-iso/pull/196 is passing now

coolbrg commented 6 years ago

@gbraad , Please rebase your PR. I have merged https://github.com/minishift/minishift-centos-iso/pull/195

gbraad commented 6 years ago

pushed