search

minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Add new target In Makefile to just create the kickstart files #181

Closed praveenkumar closed 6 years ago

praveenkumar commented 6 years ago

Currently kickstart file is getting generated inside the make rhel_iso/ centos_iso target but we are also doing the ISO creation i.e. iso_creation in the same target. However if an user want to use a different build system e.g. RH build system, user just need the kickstart file to feed in to the build system.

LalatenduMohanty commented 6 years ago

Resolved via https://github.com/minishift/minishift-centos-iso/pull/182

praveenkumar commented 6 years ago

@LalatenduMohanty looks like changes which I did to remove duplication doesn't work :( because if you try now make rhel_iso then also you get build/centos_7.ks because as per GNU rule target variable should be in the target https://www.gnu.org/software/make/manual/html_node/Target_002dspecific.html . I am going to reopen it and send PR again.

LalatenduMohanty commented 6 years ago

@praveenkumar I see, I had tested the CentOS tagets but not the RHEL.

LalatenduMohanty commented 6 years ago

Resolved via https://github.com/minishift/minishift-centos-iso/pull/183