minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Adding Makefile and creating script to partition and mount data partition #19

Closed hferentschik closed 8 years ago

hferentschik commented 8 years ago

Addresses issue #13 and issue #18

hferentschik commented 8 years ago

@praveenkumar I've added a new commit c22cf42 which adds a new systemd unit file. This seems to make it work for me. No idea why this does not seem to be required for you. See also https://github.com/docker/docker/issues/25098. WDYT?

hferentschik commented 8 years ago

BTW, what docker version do you end up with? I end up with 1.10.3, which seems rather old. Maybe something else goes wrong earlier on and I end up with an old Docker version which forces me to add this additional systemd file?

praveenkumar commented 8 years ago

what docker version do you end up with?

Because that's what in the CentOS tree.

$ docker-machine ls
NAME          ACTIVE   DRIVER   STATE     URL                         SWARM   DOCKER    ERRORS
centos        -        kvm      Running   tcp://192.168.42.46:2376            v1.10.3   
praveenkumar commented 8 years ago

No idea why this does not seem to be required for you. See also docker/docker#25098. WDYT?

@hferentschik I did test with virtualbox driver and looks like that also working as expected without any addition of that file.

➜ github docker-machine ls
NAME          ACTIVE   DRIVER       STATE     URL                         SWARM   DOCKER    ERRORS
centos-live   -        virtualbox   Running   tcp://192.168.99.100:2376           v1.10.3    
hferentschik commented 8 years ago

I did test with virtualbox driver and looks like that also working as expected without any addition of that file.

Ok, so the Docker version seems to be the same. I am a bit at loss why I see this problem and I need to create this docker.socker systemd unit file. GIven the old version of Docker, it seems to make sense. AFAIU this file was indeed used/required in older Docker versions. Something is not quite right here yet.

What about we merge the pull request without the c22cf42 commit? I think the actual formatting and mounting aspect of issue #13 is addressed. c22cf42 belongs probably more to issue #20 anyways. We need to find out why we see different behavior here. Let's continue discussing on issue #20

praveenkumar commented 8 years ago

What about we merge the pull request without the c22cf42 commit?

yes that make sense, and discuss about certificate generation on issue #20

hferentschik commented 8 years ago

yes that make sense, and discuss about certificate generation on issue #20

+1

praveenkumar commented 8 years ago

Merged except https://github.com/LalatenduMohanty/centos-live-iso/commit/c22cf42cb3b1cc87351077fdd3c778d229a2551d and discussion is on issue #20

hferentschik commented 8 years ago

Thanks.