search

minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Add basic application deployment testcase #214

Open coolbrg opened 6 years ago

coolbrg commented 6 years ago

As part of testing ISO per PR, we should also check the basic application deployment.

gbraad commented 6 years ago

This would be easy to accomplish when the testsuite/testharness is available

@agajdosi can you have a look at this and explain what is needed?

coolbrg commented 6 years ago

This would be easy to accomplish when the testsuite/testharness is available

Are you suggesting to use testsuite to replace shell based tests ?

gbraad commented 6 years ago

Add a feature for the basic flow... but perhaps in long-term, yes...

LalatenduMohanty commented 6 years ago

This would be easy to accomplish when the testsuite/testharness is available

I think this is a good idea. We can copy relevant tests from Minishift repository to here. Then we do not have to rewrite the tests for CentOS ISO.

agajdosi commented 6 years ago

@gbraad Thanks for ping, will take a look on it and update once I have any progress. But I am afraid I would not be able to start with it sooner than on Friday.

gbraad commented 6 years ago

it is not a critical, but rather a 'would-like-to-bring-to-your-attention'.

agajdosi commented 6 years ago

@budhrg, @gbraad, @LalatenduMohanty I have created a WIP PR #218 for this issue. Mostly it is just prove of concept, but I would be glad for any suggestion, especially about what to add to the feature file, which cases are problematic with CentOS and tests should focus on.