minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #216 Fix SELinux label for docker during bind mount #217

Closed praveenkumar closed 6 years ago

coolbrg commented 6 years ago

Working! :+1:

$ oc logs -f bc/ruby-ex
Cloning "https://github.com/openshift/ruby-ex.git" ...
    Commit: bbb670185b6ce67294cc461ae9c18710e6f26089 (Merge pull request #18 from durandom/master)
    Author: Ben Parees <bparees@users.noreply.github.com>
    Date:   Thu Dec 7 14:53:36 2017 -0500
---> Installing application source ...
---> Building your Ruby application from source ...
---> Running 'bundle install --retry 2 --deployment --without development:test' ...
Fetching gem metadata from https://rubygems.org/...............
Installing puma 3.10.0
Installing rack 2.0.3
Using bundler 1.7.8
Your bundle is complete!
Gems in the groups development and test were not installed.
It was installed into ./bundle
---> Cleaning up unused ruby gems ...
Pushing image 172.30.1.1:5000/myproject/ruby-ex:latest ...
Pushed 0/10 layers, 1% complete
Pushed 1/10 layers, 14% complete
Pushed 2/10 layers, 23% complete
Pushed 3/10 layers, 31% complete
[...]

cc @gbraad @LalatenduMohanty

Tested with ISO http://artifacts.ci.centos.org/minishift/minishift-centos-iso/pr/217

praveenkumar commented 6 years ago

@budhrg wow you tested it fast, let me also just test it and then see how it goes.

coolbrg commented 6 years ago

SELinux lable for docker on start

[docker@minishift ~]$  ls -lZ /var/lib/ | grep docker
drwxr-xr-x. root root    system_u:object_r:unlabeled_t:s0 boot2docker
drwx--x--x. root root    system_u:object_r:container_var_lib_t:s0 docker
gbraad commented 6 years ago

Ah, bind mounts...

praveenkumar commented 6 years ago

@amitkrout and @agajdosi are running it so we need to wait until their test results before we merge it.

gbraad commented 6 years ago

what is the ETA?

On Tue, Feb 13, 2018 at 11:52 PM, Praveen Kumar notifications@github.com wrote:

@amitkrout https://github.com/amitkrout and @agajdosi https://github.com/agajdosi are running it so we need to wait until their test results before we merge it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/minishift/minishift-centos-iso/pull/217#issuecomment-365308974, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZtfUHvEJRpmW_xajkYTAns7S2kK9ks5tUa-6gaJpZM4SDq6q .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

amitkrout commented 6 years ago

Due to slow download speed make integration_all timed out. Only three features file (xpaas, basic and cmd addons) has been executed. However there is a failure in xpaas EAP7.0 which is not an issue with centos7.iso

EAP7.0 Failure log

[ERROR] Failed to execute goal on project jboss-kitchensink: Could not resolve dependencies for project org.jboss.quickstarts.eap:jboss-kitchensink:war:7.0.0.GA: Failed to collect dependencies at org.hibernate:hibernate-validator:jar:5.2.4.Final-redhat-1 -> com.fasterxml:classmate:jar:1.1.0: Failed to read artifact descriptor for com.fasterxml:classmate:jar:1.1.0: Could not transfer artifact [...]

To run it quickly i downloaded the iso [1] and running the command.

MINISHIFT_ISO_URL=file:///home/amit/Downloads/minishift-centos7.iso make integration_all

[1] http://artifacts.ci.centos.org/minishift/minishift-centos-iso/pr/217/minishift-centos7.iso Will update the result once done

praveenkumar commented 6 years ago

I also run all the integration test e2e and everything was working as expected.