search

minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

FIX: restore host keys after restart #266

Open rbock44 opened 5 years ago

rbock44 commented 5 years ago

Currently because of the livecd rootfs the host keys are lost. After a restart the host gets new keys. This causes problems with e.g. ssh which stores the public keys in known_hosts. Instead of messing around with ssh config it is easier to just restore the keys in case the machine was not newly created.

To keep this apart from user data I basically copied this to host-key handling.

centos-ci commented 5 years ago

Can one of the admins verify this patch?

praveenkumar commented 5 years ago

ok to test.

rbock44 commented 5 years ago

I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template

gbraad commented 5 years ago

Please copy-paste and we will verify

On Mon, Dec 31, 2018 at 8:46 PM rbock44 notifications@github.com wrote:

I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

gbraad commented 5 years ago

Besides, you are entitled to open a developer account on developer.redhat.com, which grants you to download/use an instance of RHEL

On Mon, Dec 31, 2018 at 9:33 PM Gerard Braad me@gbraad.nl wrote:

Please copy-paste and we will verify

On Mon, Dec 31, 2018 at 8:46 PM rbock44 notifications@github.com wrote:

I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

rbock44 commented 5 years ago

OK. I added the changes also to the redhat template in a second commit. Thanks for the hint on the redhat developer license. Will follow up soon on this.