minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Issue #61: Adding cdk-entitlements RPM to RHEL ISO #69

Closed LalatenduMohanty closed 7 years ago

LalatenduMohanty commented 7 years ago

Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com

coolbrg commented 7 years ago

I have tested the PR with iso created from PR branch.

Found cdk-entitlements-1-2.el7.noarch package installed with rpm -qa cdk-entitlements. However, starting with minishift binary stuck on getting IP.

However, the customized iso given by @praveenkumar to test https://github.com/minishift/minishift/pull/222 works fine and getting IP.

@praveenkumar Anything missing from current PR for ISO ?

LalatenduMohanty commented 7 years ago

@budhrg @praveenkumar I tested the PR against minishift master and everything working fine for me on OS X. I also tested on KVM and seeing some issue. But the issue is not this PR related as I can reproduce without the PR too. I am preety sure the KVM issue is a different issue and not related to this PR.

coolbrg commented 7 years ago

I also tested on KVM and seeing some issue.

I had the issue of "Not getting IP" in Virtualbox 5.0.30 Fedora 24 with minishift master branch.

praveenkumar commented 7 years ago

@LalatenduMohanty Please rebase it with master.

LalatenduMohanty commented 7 years ago

@budhrg Can you please test the current master of minishif-centos-iso without this PR? As logically cdk-entitlments package should not be related to the networking issue you are seeing.

coolbrg commented 7 years ago

Can you please test the current master of minishif-centos-iso without this PR? As logically cdk-entitlments package should not be related to the networking issue you are seeing.

@LalatenduMohanty With current master of minishift-centos-iso is working fine (without PR) with current minishift master

$ minishift start --vm-driver virtualbox --iso-url file:///home/budhram/gowork/src/github.com/minishift/minishift/minishift-centos.iso
Starting local OpenShift cluster...
Distribution doesn't support registration
 18.63 MB / 18.63 MB [============================================================================================================================] 100.00% 0s
Provisioning OpenShift via '/home/budhram/.minishift/cache/oc/v1.3.1/oc [cluster up]'
-- Checking OpenShift client ... OK
-- Checking Docker client ... OK
-- Checking Docker version ... OK
-- Checking for existing OpenShift container ... OK
-- Checking for openshift/origin:v1.3.1 image ... 
   Pulling image openshift/origin:v1.3.1
   Pulled 0/3 layers, 3% complete
   Pulled 0/3 layers, 56% complete
   Pulled 1/3 layers, 68% complete
   Pulled 2/3 layers, 85% complete
   Pulled 3/3 layers, 100% complete
   Extracting
   Image pull complete
-- Checking Docker daemon configuration ... OK
-- Checking for available ports ... OK
-- Checking type of volume mount ... 
   Using nsenter mounter for OpenShift volumes
-- Creating host directories ... OK
-- Finding server IP ... 
   Using 192.168.99.101 as the server IP
-- Starting OpenShift container ... 
   Creating initial OpenShift configuration
   Starting OpenShift using container 'origin'
   Waiting for API server to start listening
   OpenShift server started
-- Installing registry ... OK
-- Installing router ... OK
-- Importing image streams ... OK
-- Importing templates ... OK
-- Login to server ... OK
-- Creating initial project "myproject" ... OK
-- Server Information ... 
   OpenShift server started.
   The server is accessible via web console at:
       https://192.168.99.101:8443

   You are logged in as:
       User:     developer
       Password: developer

   To login as administrator:
       oc login -u system:admin
praveenkumar commented 7 years ago

Tested and works as expected 👍