minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

The ISO name should contain the major version of Distribution e.g. minishift-centos7 #75

Closed LalatenduMohanty closed 7 years ago

LalatenduMohanty commented 7 years ago

ISO names should be minishift-centos7 and minishift-rhel7 instead of minishift-centos or minishift-rhel as it will make the ISO more specific to the distribution version it is based upon. Also it will help in future to differentiate between CentOS6 or CentOS8.

praveenkumar commented 7 years ago

@LalatenduMohanty I think for this iso we don't need it because we are always going to create iso using what latest available and our releases are different than CentOS release cycle so if we want to advertise user to use a specific iso then we should refer it to release version which we have here.

@hferentschik @budhrg you have any thought on that?

coolbrg commented 7 years ago

I think adding version number along with ISO name will add a movable component and might be difficult to maintain. I believe we need to create one more const/var somewhere to decide this version and then make sure that it is same across minishift ecosystem.

However, the idea is good but for me it looks like adding maintenance overhead until @LalatenduMohanty ensure me it is not :) and how we can maintian stability across minishift ecosystem.

LalatenduMohanty commented 7 years ago

@praveenkumar @budhrg having the major version number in the name gives more clarity about what is the version of RHEL or CentOS it is built on without starting the VM. I am only taking about just adding single numerical 7 for CentOS7 or RHEL 7. the number 7 It is not going to change in its lifetime.