search

minishift / minishift-centos-iso

CentOS based ISO as an alternative for boot2docker ISO
GNU Lesser General Public License v3.0
40 stars 33 forks source link

Docker service file should be persistent across reboot #83

Closed praveenkumar closed 7 years ago

praveenkumar commented 7 years ago

Currently our docker service file is not persistent when reboot happen so if a user make some modification around docker service file then it get lost after restart. We should make it persistent by adding it to handle-user-data script.

gbraad commented 7 years ago

Should we allow modifications to the unit file? This seems quite futile, as the files are in the live-rw filesystem... and on start, the provisioner overwrites them anyways...

hferentschik commented 7 years ago

Should we allow modifications to the unit file? This seems quite futile, as the files are in the live-rw filesystem..

Well the intend of this issue is to make sure the unit file would be persistent and not part of the live-rw. Whether this is required or a good idea in general is what we try to establish.

hferentschik commented 7 years ago

@praveenkumar Do we still need this? Does it makes sense to have this issue open or should we close it?

praveenkumar commented 7 years ago

@hferentschik we don't require it anymore. I am closing this issue now.

hferentschik commented 7 years ago

+1 thanks