App does not accept NHS Scotland QR code

ministero-salute / it-dgc-verificaC19-android

VerificaC19 is the official Italian customization of the EU Digital COVID Certificate Verifier App for the Android Operating System

https://www.dgc.gov.it

Apache License 2.0

101 stars 54 forks source link

App does not accept NHS Scotland QR code #135

Closed MichalBryxi closed 3 years ago

MichalBryxi commented 3 years ago

Describe the bug

On scanning my NHS Scotland QR code I get following screen saying "Certificazione non valida":

Photo on 16-09-2021 at 08 07

Expected behaviour

Since NHS certificates are deemed valid, I'd expect NHS Scotland be also accepted.

Steps to reproduce the issue

Scan a QR code issued by NHS Scotland.

Technical details

Android 11
App version: 1.1.0 (updated on: 9. Aug 2021), which seems to have the patch mentioned above

Additional notes

I was able to load my certificate to Swiss version of the app (still claiming it's invalid) and the details I see are:

photo_2021-09-16 08 16 49

photo_2021-09-16 08 16 46

I redacted the URN as I don't have the knowledge whether that is a private information or not.
I can share the QR codes for examination. I assume those are private information and should not be uploaded to GitHub.

MichalBryxi commented 3 years ago

Just realised:

I don't have a control NHS England QR code to check that the app actually accepts NHS England codes.
I am happy to share additional data (even the scan of the whole NHS Scotland certificate) once someone gives me confirmation that these are ok to share (I don't really care about publishing my name or DOB, but am worried about someone using my covid passport)

gwr3n commented 3 years ago

I can confirm I am facing the same issue. Please note that NHS Scotland is a separate body from NHS England, so it is likely to use a different key/signature.

gwr3n commented 3 years ago

If it can be of any help, I believe the body in charge of producing NHS Scotland COVID passes is www.nss.nhs.scot they are quite active on Twitter @NHSNSS

BonjoDan commented 3 years ago

I don't know if it can help. Just to let you know. The app on the Apple Store called "NHS Scotland COVID Check" developed by NHS Education for Scotland is working perfectly (naturally). Here the link:

https://apps.apple.com/gb/app/nhs-scotland-covid-check/id1583924545

Let me know if I can hep in some way.

MichalBryxi commented 3 years ago

That might eventually help @BonjoDan, thank you. I can't find Android version though. Do you have a clue?

BonjoDan commented 3 years ago

Maybe this one?

https://play.google.com/store/apps/details?id=scot.nhs.nss.checkin&hl=en_US&gl=US

BonjoDan commented 3 years ago

I have an Android phone as well so I can test it.

BonjoDan commented 3 years ago

No, sorry. Unfortunately it seems a different app.

astagi commented 3 years ago

@gwr3n @BonjoDan @MichalBryxi DSC uploaded to production env. I made some tests and everything works as expected! 🏴󠁧󠁢󠁳󠁣󠁴󠁿