ministero-salute / it-dgc-verificaC19-android

VerificaC19 is the official Italian customization of the EU Digital COVID Certificate Verifier App for the Android Operating System
https://www.dgc.gov.it
Apache License 2.0
101 stars 54 forks source link

Fix: person details when fn and gn are missing #257

Closed rawmain closed 2 years ago

rawmain commented 2 years ago

This PR fixes output display issues with those certificates that don't include the fn (familyName) and gn (givenName) fields, but for instance only the fnt field.


Issue Details :

Some foreign certificates only include the fnt field = no fn and gn fields. Therefore - owing to the current declaration of fun setPersonData - the validation output of such certificates doesn't contain any person details of the certificate holder.


Fix description :

It checks if the fn field name is null/empty.

rawmain commented 2 years ago

@it-eucert-team + @nicola-95 + @Kaizen-7 + @astagi

Fix is working flawlessly with current develop + feature code, so there should be no issues to include it in the upcoming 1.2.5 release.

Already submitted the same fix PR for iOS too.