ministero-salute / it-dgc-verificaC19-android

VerificaC19 is the official Italian customization of the EU Digital COVID Certificate Verifier App for the Android Operating System
https://www.dgc.gov.it
Apache License 2.0
101 stars 54 forks source link

Standardised Name is not used in the Verification fragment #82

Closed DimPaDev closed 1 year ago

DimPaDev commented 3 years ago

Describe the bug

When a QR code is being verified and the app shows the personal data of the user only the original type of the name is visible. Instead , ( like similar apps from other european countries do ) the app should also show the STANDARDISED type of the name and the last name. This will be useful when the original name and the original last name of the user is using non-latin characters ( for example a person with two nationalities ) and the verification process through an identity card from an authority in Italy will be easier.

Expected behaviour

The app should also show the STANDARDISED type (with latin characters) of the name and the last name in the verification fragment.

Possible Fix

In order to do that, only one line should be edited :

https://github.com/ministero-salute/it-dgc-verificaC19-android/blob/develop/app/src/main/java/it/ministerodellasalute/verificaC19/ui/main/verification/VerificationFragment.kt

LINE 247 -->

FROM :

binding.nameStandardisedText.text = ""

TO :

binding.nameStandardisedText.text = person.standardisedFamilyName.plus(" ").plus(person.standardisedGivenName)

enricomiletto commented 3 years ago

You could also consider implementing something like what @admin-ch did. The first and last name fields show the name in the original language charachters, but lower there's a string showing how the name would appreat on the MRZ (machine readable zone) of the ID card/passport of the DCC's holder, which by the ICAO standard only contain the standardized latin charachters

WIN_20210802_23_59_46_Pro_LI

Immagine 2021-08-03 001810

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.