ministero-salute / it-dgc-verificaC19-android

VerificaC19 is the official Italian customization of the EU Digital COVID Certificate Verifier App for the Android Operating System
https://www.dgc.gov.it
Apache License 2.0
101 stars 54 forks source link

All test QR codes on the main EU dgc's repository generated by the Italian's Team do NOT verify #87

Closed vincenzoiovino closed 3 years ago

vincenzoiovino commented 3 years ago

Describe the bug

I tested all QR codes available here: https://github.com/eu-digital-green-certificates/dgc-testdata/tree/main/IT The verification fails for ALL of them. Notwithstanding: 1) I can verify other QR codes (not present in the list above) and 2) other verification apps from UE (and not only) can verify the QR codes given in the link above.

Additional info

It seems that after the instruction "val key = db.keyDao().getById(kid)" of getCertificate in VerifierRepository, key is null. What does it mean?

astagi commented 3 years ago

Hi @vincenzoiovino these certificates are only for test purpose and don't have a valid signature. As you can see some apps are currently showing the information taken from DCC payload, we're working on a new UI to make those data available for VerificaC19 too.

vincenzoiovino commented 3 years ago

Hi @vincenzoiovino these certificates are only for test purpose and don't have a valid signature. As you can see some apps are currently showing the information taken from DCC payload, we're working on a new UI to make those data available for VerificaC19 too.

So, would then the bug be in the EU and other National apps? The EU official app and the Swiss one Covid Certificate, only to mention some, do verify successfully the above codes. What is going on?

astagi commented 3 years ago

@vincenzoiovino I tried Covid Check Swiss app and I get this

IMG_0096 IMG_0098

vincenzoiovino commented 3 years ago

wit the EU app I get: WIN_20210802_19_06_48_Pro (2)

and the Swiss Covid Cert app I get: image

However it only later says the sig is invalid. So the issue would be only in the EU app that shows green sign.

astagi commented 3 years ago

@vincenzoiovino yes this behaviour only affects the EU app. Thanks for having reported this problem!