ministero-salute / it-dgc-verificac19-sdk-android

Digital Covid Certificate SDK
Apache License 2.0
57 stars 30 forks source link

Potential regression in vaccineStandardStrategy #130

Closed DevTrevi closed 2 years ago

DevTrevi commented 2 years ago

Hi everyone,

in the new vaccineStandardStrategy in the upcoming version 1.1.5, the rules read from service are always referred to "IT" (Italy), but they was implemented in this way just a few commits before:

val countryCode = if (scanMode == ScanMode.STANDARD) vaccination.countryOfVaccination else Country.IT.value

Is this a regression or it is an intended change?

rawmain commented 2 years ago

Hello @DevTrevi

in the new vaccineStandardStrategy in the upcoming version 1.1.5, the rules read from service are always referred to "IT" (Italy), but they was implemented in this way just a few commits before [...] Is this a regression or it is an intended change?

It's an intended change. Current arrangement for some Vaccine Validation Strategy ruleset values' choice relies indeed on :

EMA checks (mp / extendedDays) for status override rely instead always on (vaccination.medicinalProduct, vaccination.countryOfVaccination).

DevTrevi commented 2 years ago

Thank you @rawmain