search

ministero-salute / it-dgc-verificac19-sdk-android

Digital Covid Certificate SDK
Apache License 2.0
57 stars 30 forks source link

Feature/remove school mode #162

Closed nicola-95 closed 2 years ago

nicola-95 commented 2 years ago

@astagi, line 185 of RuleSet.kt, after commit bf00373, points to isEma() method. Is this the change you are pointing out? Do I have to delete this method?

astagi commented 2 years ago

@astagi, line 185 of RuleSet.kt, after commit bf00373, points to isEma() method. Is this the change you are pointing out? Do I have to delete this method?

no sorry, I'm talking about validation/VaccineValidationStrategy.kt file. There is a line that does nothing, I left a comment on the previous PR https://github.com/ministero-salute/it-dgc-verificac19-sdk-android/pull/161/files#r838488132

nicola-95 commented 2 years ago

https://github.com/ministero-salute/it-dgc-verificac19-sdk-android/pull/161/files#r838488132

It's OK, I just deleted that line. Change pushed.

astagi commented 2 years ago

https://github.com/ministero-salute/it-dgc-verificac19-sdk-android/pull/161/files#r838488132

It's OK, I just deleted that line. Change pushed.

thank you so much @nicola-95 🙌