ministryofjustice / analytical-platform

Analytical Platform • This repository is defined and managed in Terraform
https://docs.analytical-platform.service.justice.gov.uk
MIT License
12 stars 4 forks source link

🐛 Data Engineering cleanup is still removing Cost Anomaly resources #2763

Closed jacobwoffenden closed 4 months ago

jacobwoffenden commented 10 months ago

Describe the bug.

https://github.com/ministryofjustice/data-engineering-cleanup/pull/15 should've filtered out all the Cost Anomaly resources, but some were missed.

After DE ran AWS nuke earlier in December, the following resources were deleted

# module.data_engineering_sandbox_a_cost_explorer_anomaly_monitor.aws_kms_key.ce_anomaly_monitor has been deleted
  - resource "aws_kms_key" "ce_anomaly_monitor" {
        id                                 = "82a4d38b-eabd-45a7-afc9-2866f6dd5f55"
      - key_id                             = "82a4d38b-eabd-45a7-afc9-2866f6dd5f55" -> null
        tags                               = {}
        # (10 unchanged attributes hidden)
    }

  # module.data_engineering_sandbox_a_guardduty_eu_west_1.aws_kms_key.guardduty_findings has been deleted
  - resource "aws_kms_key" "guardduty_findings" {
        id                                 = "a81b3a4e-68ae-47da-962d-23d45b20baf9"
      - key_id                             = "a81b3a4e-68ae-47da-962d-23d45b20baf9" -> null
        tags                               = {}
        # (10 unchanged attributes hidden)
    }

  # module.data_engineering_sandbox_a_guardduty_eu_west_2.aws_kms_key.guardduty_findings has been deleted
  - resource "aws_kms_key" "guardduty_findings" {
        id                                 = "5[373](https://github.com/ministryofjustice/data-platform/actions/runs/7220361506/job/19673117535?pr=2752#step:13:374)bee9-5718-4c52-97e8-8a7c47606467"
      - key_id                             = "5373bee9-5718-4c52-97e8-8a7c47606467" -> null
        tags                               = {}
        # (10 unchanged attributes hidden)
    }

  # module.data_engineering_sandbox_a_guardduty_eu_west_2.aws_sns_topic.guardduty_findings has been deleted
  - resource "aws_sns_topic" "guardduty_findings" {
      - arn                                      = "arn:aws:sns:eu-west-2:684969100054:guardduty-findings" -> null
        id                                       = "arn:aws:sns:eu-west-2:684969100054:guardduty-findings"
        name                                     = "guardduty-findings"
        tags                                     = {}
        # (12 unchanged attributes hidden)
    }

https://github.com/ministryofjustice/data-platform/actions/runs/7220361506/job/19673117535?pr=2752#step:13:986

To Reproduce

No response

Expected Behaviour

Cost Anomaly resources aren't deleted

Additional context

No response

github-actions[bot] commented 8 months ago

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

github-actions[bot] commented 6 months ago

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

github-actions[bot] commented 4 months ago

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

github-actions[bot] commented 4 months ago

This issue is being closed because it has been open for a further 7 days with no activity. If this is still a valid issue, please reopen it, Thank you!