ministryofjustice / analytics-platform

Parent repository for the MOJ Analytics Platform
MIT License
14 stars 1 forks source link

Problems with some email addresses in the control panel #37

Closed RobinL closed 6 years ago

RobinL commented 6 years ago

Users are experiencing problems with some email addresses and some apps in Auth 0

screen shot 2018-07-05 at 13 30 17
RobinL commented 6 years ago

This looks like it's a problem with Auth0 getting confused.

In the situation where the app customer (who should have an email connection in Auth0) has an AP account, they get added to the app with a Github Connection.

Here's a reproducable example:

Remove lewis.crouch@justice.gov.uk from feedback app in control panel (apps/36). Re-add him. Log into Auth0 -> extensions -> authorization extension -> groups -> feedback app. He shows up with a github connection

RobinL commented 6 years ago

This is a bit weird though because we definitely have AP users who are part of feedback app as 'email' connections. Examples of this are me, jon roberts, mikael

andyhd commented 6 years ago

I took a quick look at this yesterday, and I can see that Katy successfully logged into crime-in-prisons many times in the past. The Auth0 logs show a CORS error with the last login to crime-in-prisons, but I don't know for certain if that was when Katy was trying to login. I'll investigate.

andyhd commented 6 years ago

I can reproduce the bug when adding a customer to an app with the same email as an existing platform user. The Control Panel checks whether a customer already exists with the specified email and adds them to the app if they do - but the bug is that it doesn't differentiate between customers and platform users, who do not have permission to receive OTP emails. I have a fix for this waiting to be merged now.

sarahwebb81 commented 6 years ago

I still cannot log on to the Server, I am getting an error message "We're sorry something went wrong". When will this be resolved?

andyhd commented 6 years ago

This fix has now been deployed. @sarahwebb81 I checked your access specifically, and you should be able to login now.