🔥 Remove `tfsec` Since `trivy` is Already Running - Githubissues

ministryofjustice / aws-root-account

Terraform for the Ministry of Justice AWS root account

MIT License

80 stars 18 forks source link

🔥 Remove `tfsec` Since `trivy` is Already Running #983

Closed connormaglynn closed 2 months ago

connormaglynn commented 2 months ago

👀 Purpose

In relation to #973
To remove deprecated tool tfsec (trivy is already setup and running)

♻️ What's changed

Removed tfsec from the terraform tools workflow

📝 Notes

Vendor has stated they recommend using trivy over tfsec. Trivy is already running in this repository so we're duplicating effort by having both. Also tfsec is currently broken, so removing this will aid in not seeing a failing pipeline for every PR and merge 🥳
Kept terraform tools workflow since this still runs tflint which we'll migrate over to megalinter ♻️

github-actions[bot] commented 2 months ago

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
❌ ACTION	actionlint	1		2	0.02s
❌ REPOSITORY	gitleaks	yes		2	0.83s
✅ REPOSITORY	trivy	yes		no	9.93s
✅ YAML	prettier	1		0	0.39s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by _