Make sure that set_active_stack activates all ELBs. - Githubissues

ministryofjustice / bootstrap-cfn

Opinionated layer for AWS CloudFormation

Other

17 stars 9 forks source link

Make sure that set_active_stack activates all ELBs. #234

Closed kwilczynski closed 8 years ago

kwilczynski commented 8 years ago

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

kwilczynski commented 8 years ago

To be completed:

[x] Modify set_active_stack to work with multiple public ELBs
[x] Locate other places in the code where get_first_public_elb() is also invoked
- [x] Modify cfn_delete to remove DNS entries for all ELBs
- [x] Modify get_active_stack to work with all ELBs
[x] Handle "dualstack" fully-qualified URLs
[x] Update unit tests
[x] Test using single and multiple ELBs stacks

kwilczynski commented 8 years ago

@ltsampros @yufangzhang hi there! Please review.

coveralls commented 8 years ago

Changes Unknown when pulling 8e9d3682377ce6eb43fbd8f27c19383b4263d089 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

kwilczynski commented 8 years ago

More things need to be done in here as per the new requirements from @yufangzhang.

coveralls commented 8 years ago

Changes Unknown when pulling b7c0de6ac823564305409712fcef1806c6f677e1 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

coveralls commented 8 years ago

Changes Unknown when pulling a38a063587a6d0d7888e8d841c3063ddc985028d on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

coveralls commented 8 years ago

Changes Unknown when pulling 4d0bedaa201d8cd3af6efba73180c062d3416905 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

coveralls commented 8 years ago

Changes Unknown when pulling 0ccfebf5e442820717d6de12663039dba1980ab4 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

coveralls commented 8 years ago

Changes Unknown when pulling e8c8fa157635cb4ecf2cab0db51a0ac0cf30acc0 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

coveralls commented 8 years ago

Changes Unknown when pulling 2ab4a9f1c07201ea1c49c043adea64561ee84b36 on kwilczynski:feature/update-set_active_stack into on ministryofjustice:master.

ltsampros commented 8 years ago

Looks good to me! @kwilczynski