(WIP) Remove DNS tag in the event of rollback

ministryofjustice / bootstrap-cfn

Opinionated layer for AWS CloudFormation

Other

17 stars 9 forks source link

(WIP) Remove DNS tag in the event of rollback #253

Closed mattpep closed 7 years ago

mattpep commented 7 years ago

Fixes #221

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 59.786% when pulling 9f21a23a94030df6d5b8a250618611d4fe91e085 on dnstag_fix into 194ffb4c4240d934be6075043561095da4f5ce20 on master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 59.786% when pulling 09f29ad580eaed851e61b63cc942e24661923a86 on dnstag_fix into 194ffb4c4240d934be6075043561095da4f5ce20 on master.

lukaszraczylo commented 7 years ago

@mattpep & @yufangzhang any consensus on this or progress in merge?

sevenmachines commented 7 years ago

@yufangzhang @mattpep @ltsampros Not quite sure why we're looking to delete records on rollback. We need them for cfn_delete the stack(?) Anyways, happy have my ignorance crushed by catching up and finding out :) But going to put in WIP for the moment

filipposc5 commented 7 years ago

A bit late to the party, but this PR is still open/pending. Niall's comment sounds right, if we are not dealing with a half created stack because we want to cfn_delete then we shouldn't need this PR altogether. So we should close this PR and document this expectation, perhaps under a workflow headline?

mattpep commented 7 years ago

Invalid.