search

ministryofjustice / bootstrap-cfn

Opinionated layer for AWS CloudFormation
Other
17 stars 9 forks source link

Allow multi-part policies on aditional s3 buckets #275

Closed robyoung closed 7 years ago

robyoung commented 7 years ago

AIM policy documents are made up of a list of policy statements. Currently bootstrap-cfn only allows a single custom policy for an S3 bucket. This change allows a list of custom policies to be provided. Backwards compatibility is maintained by allowing either a single policy dict or a list of policies.

I have only implemented this on the additional s3 buckets because the static buckets are for a specific use case and should be kept as simple as possible. Do you think it would make more sense to implement it the same for the static bucket and additional buckets?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 57.918% when pulling 098b1c60a53a24b50b0397ba531cc18aa1d2a5c0 on robyoung:s3-multi-part-bucket-policy into e87341663cbcb209df49db737b050bb0913aa673 on ministryofjustice:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 58.073% when pulling 5708d083991c5643e0d07683c0f1d77375f947f6 on robyoung:s3-multi-part-bucket-policy into 18a24f5ac51efe4d9609bb1278d0cf0d64fe772b on ministryofjustice:master.