search

ministryofjustice / bootstrap-cfn

Opinionated layer for AWS CloudFormation
Other
17 stars 9 forks source link

WIP: Allow logical name to be set on additional buckets #276

Closed robyoung closed 6 years ago

robyoung commented 7 years ago

AWS allows buckets to have a logical name as well as a physical name. This feature is used by upload_assets to make it easier to perform actions on a kind of bucket within an environment. This is also useful for additional S3 buckets where we need a different bucket per environment.

Backwards compatibility is maintained by introducing an additional yaml key for the logical-name which overrides the resource name. If it's not set the resource name reverts to the bucket name.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 57.911% when pulling 8a58f2659837e66b14c1a3d81f9f446a1d978b20 on robyoung:s3-logical-resource-id into e87341663cbcb209df49db737b050bb0913aa673 on ministryofjustice:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 57.911% when pulling 7b916be7870dc8c55bc2abce79c150d6192cdc00 on robyoung:s3-logical-resource-id into e87341663cbcb209df49db737b050bb0913aa673 on ministryofjustice:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 57.911% when pulling 7b916be7870dc8c55bc2abce79c150d6192cdc00 on robyoung:s3-logical-resource-id into e87341663cbcb209df49db737b050bb0913aa673 on ministryofjustice:master.

robyoung commented 7 years ago

Apparently the same effect can be achieved by using the cloudformation output.